[Skiboot] [PATCH v8 17/24] platform: Introduce new reboot type

[Vasant Hegde]

On 06/28/2019 07:13 AM, Nicholas Piggin wrote:
> Vasant Hegde's on June 17, 2019 3:10 am:
>> Enhance reboot2 call to support MPIPL. Payload will call this interface
>> to initiate MPIPL.
>>
>> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
>> ---
>>   core/platform.c                        | 8 +++++++-
>>   doc/opal-api/opal-cec-reboot-6-116.rst | 7 +++++++
>>   include/opal-api.h                     | 1 +
>>   3 files changed, 15 insertions(+), 1 deletion(-)
>>
>> diff --git a/core/platform.c b/core/platform.c
>> index afa00adf7..da3c8b175 100644
>> --- a/core/platform.c
>> +++ b/core/platform.c
>> @@ -1,4 +1,4 @@
>> -/* Copyright 2013-2016 IBM Corp.
>> +/* Copyright 2013-2019 IBM Corp.
>>    *
>>    * Licensed under the Apache License, Version 2.0 (the "License");
>>    * you may not use this file except in compliance with the License.
>> @@ -15,6 +15,7 @@
>>    */
>>   
>>   
>> +#include <stdlib.h>
>>   #include <skiboot.h>
>>   #include <opal.h>
>>   #include <console.h>
>> @@ -110,6 +111,11 @@ static int64_t opal_cec_reboot2(uint32_t reboot_type, char *diag)
>>   	case OPAL_REBOOT_FULL_IPL:
>>   		disable_fast_reboot("full IPL reboot requested");
>>   		return opal_cec_reboot();
>> +	case OPAL_REBOOT_OS_ERROR:
>> +		prlog(PR_NOTICE, "Reboot: OS reported error. Performing dump\n");
>> +		console_complete_flush();
>> +		_abort("Reboot: OS reported error. Performing dump\n");
>> +		break;
> 
> This should be re-named. It should tie in with whatever consisent names
> you expose to the OS for these facilities. The registration side is
> called OPAL_MPIPL_, so this would be better to be OPAL_REBOOT_MPIPL.

Initially I wanted this to be generic macro. So that we can replace the backend 
transparently.
Now that I have changed most of the other interfaces, I can change this one as 
well.

-Vasant