[Skiboot] [PATCH 5/7] npu2: Add checks to npu2-only codepaths

Reza Arbab arbab at linux.ibm.com
Tue Jul 2 08:02:26 AEST 2019


On Wed, Jun 26, 2019 at 03:15:18PM +1000, Alexey Kardashevskiy wrote:
>On 18/06/2019 17:17, Andrew Donnellan wrote:
>> No it doesn't, probe_npu2() is npu2 only, probe_npu3() is npu3 only.
>> They use different device tree compat strings.
>>
>
>A slightly strange pattern then. probe_npu2() is called on every
>machine, including POWER8NVL. It does not do anything because
>platform.npu2_device_detect is not defined there. Ahhh whatever...

Isn't that normal for probe functions? You call them on every machine, 
and when there's nothing to do, they return early.

-- 
Reza Arbab


More information about the Skiboot mailing list