[Skiboot] [PATCH v2 15/15] hw/npu2-opencapi: Remove completed TODO

Andrew Donnellan andrew.donnellan at au1.ibm.com
Thu Jan 31 11:41:09 AEDT 2019


On 22/1/19 12:01 pm, Alexey Kardashevskiy wrote:
> 
> 
> On 11/01/2019 12:09, Andrew Donnellan wrote:
>> We support presence detection now. Remove the TODO about that.
> 
> Since when? Please add "Fixes: sha1" of the presence detection fix.

Done in v3

> 
> 
>>
>> Suggested-by: Frederic Barrat <fbarrat at linux.ibm.com>
>> Signed-off-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>
>> ---
>>   hw/npu2-opencapi.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/hw/npu2-opencapi.c b/hw/npu2-opencapi.c
>> index 7acf3837fd40..e268b75021b1 100644
>> --- a/hw/npu2-opencapi.c
>> +++ b/hw/npu2-opencapi.c
>> @@ -25,7 +25,6 @@
>>    * TODO:
>>    *   - Support for link ganging (one AFU using multiple links)
>>    *   - Link reset and error handling
>> - *   - Presence detection
>>    *   - Consume HDAT NPU information
>>    *   - LPC Memory support
>>    */
>>
> 

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited



More information about the Skiboot mailing list