[Skiboot] [PATCH 7/9] npu2: Fix missing iteration in tce kill loop

Reza Arbab arbab at linux.ibm.com
Fri Jan 11 04:58:05 AEDT 2019


On Thu, Jan 10, 2019 at 11:05:01AM +1100, Andrew Donnellan wrote:
>This looks like it might be fixing an actual bug? Should it go to 
>stable?

Good question. Alistair can correct me, but it was my understanding that 
the NVIDIA driver doesn't exercise this codepath. It doesn't use 
OPAL_PCI_TCE_KILL_PAGES, only KILL_PE/KILL_ALL. So there would be no 
exposure here.

I guess in principle it should still go to stable? If so, I can put

Cc: stable # v5.5+
Fixes: d8c880ecc2c8 ("Introduce NPU2 support")

on this patch in v2. Stewart, any guidance here?

-- 
Reza Arbab



More information about the Skiboot mailing list