[Skiboot] [PATCH v3 4/8] phb4/capp: Update and re-factor phb4_set_capi_mode()

Vaibhav Jain vaibhav at linux.ibm.com
Fri Jan 11 01:18:49 AEDT 2019

Hi Fred,

Thanks for reviewing this patch.

Frederic Barrat <fbarrat at linux.ibm.com> writes:
>> -	offset = PHB4_CAPP_REG_OFFSET(p);
>> -	xscom_read(p->chip_id, CAPP_ERR_STATUS_CTRL + offset, &reg);
>> -	if ((reg & PPC_BIT(5))) {
>> -		PHBERR(p, "CAPP: recovery failed (%016llx)\n", reg);
>> -		return OPAL_HARDWARE;
> It seems that we're no longer testing for that bit and have a permanent 
> failure if a reovery failed before. Is the logic that we might as well 
> try to switch state anyway and see how that goes?
CAPP recovery failed is a checkstop event and only way to recover from
it will be to do a full ipl reboot. This will anyways reset the CAPP
state hence this check was redundant.

Vaibhav Jain <vaibhav at linux.ibm.com>
Linux Technology Center, IBM India Pvt. Ltd.

More information about the Skiboot mailing list