[Skiboot] [PATCH] hw/imc: Fix opal_imc_counters_* return for unknown type

Stewart Smith stewart at linux.vnet.ibm.com
Thu Jan 10 09:06:06 AEDT 2019

Madhavan Srinivasan <maddy at linux.vnet.ibm.com> writes:
> Commit 7801be0fcf2a2 ('skiboot: Add opal calls to init/start/stop IMC devices')
> added opal_imc_counters_* calls to program and control the In-Memory
> Collection(IMC) counter feature of the Power9 system. These opal calls
> take "type" as input parameter to differentiate the device or domain to
> work with. Even though, is_imc_device_type_supported() and
> check_imc_device_type() is called at boot to remove any unknown imc
> devices in the device tree, it is still better to return "OPAL_PARAMETER"
> in the opal_imc_counters_* for any unknown type value passed.

this seems to constitute an API change. What is the effect on current
kernels? There should also be an update to the documentation for these
calls explaining the current behaviour as well as noting that prior to
version X there was this other behaviour.

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list