[Skiboot] [PATCH v3 8/8] capp/phb4: Prevent HMI from getting triggered when disabling CAPP

christophe lombard clombard at linux.vnet.ibm.com
Thu Jan 10 00:04:22 AEDT 2019

Le 08/01/2019 à 10:59, Vaibhav Jain a écrit :
> While disabling CAPP an HMI gets triggered as soon as ETU is put in
> reset mode. This is caused as before we can disabled CAPP, it detects
> PHB link going down and triggers an HMI requesting Opal to perform
> CAPP recovery. This has an un-intended side effect of spamming the
> Opal logs with malfunction alert messages and may also confuse the
> user.
> To prevent this we mask the CAPP FIR error 'PHB Link Down' Bit(31)
> when we are disabling CAPP just before we put ETU in reset in
> phb4_creset(). Also now since bringing down the PHB link now wont
> trigger an HMI and CAPP recovery, hence we manually set the
> PHB4_CAPP_RECOVERY flag on the phb to force recovery during creset.
> Reviewed-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>
> Signed-off-by: Vaibhav Jain <vaibhav at linux.ibm.com>
> ---
> Change-log
> v3:	Fetch the pointer to 'struct capp' from struct phb4 instead of
> 	struct phb.
> v2:	Use the member 'struct capp->capp_xscom_offset' to find the
> 	xscom register offset instead of 'PHB4_CAPP_REG_OFFSET'.
> ---

Reviewed-by: Christophe Lombard <clombard at linux.vnet.ibm.com>

More information about the Skiboot mailing list