[Skiboot] [PATCH v3 7/8] phb4/capp: Implement sequence to disable CAPP and enable fast-reset

[christophe lombard]

Le 08/01/2019 à 10:59, Vaibhav Jain a écrit :
> We implement h/w sequence to disable CAPP in disable_capi_mode() and
> with it also enable fast-reset for CAPI mode in phb4_set_capi_mode().
> 
> Sequence to disable CAPP is executed in three phases. The first two
> phase is implemented in disable_capi_mode() where we reset the CAPP
> registers followed by PEC registers to their init values. The final
> third final phase is to reset the PHB CAPI Compare/Mask Register and
> is done in phb4_init_ioda3(). The reason to move the PHB reset to
> phb4_init_ioda3() is because by the time Opal PCI reset state machine
> reaches this function the PHB is already un-fenced and its
> configuration registers accessible via mmio.
> 
> Reviewed-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>
> Signed-off-by: Vaibhav Jain <vaibhav at linux.ibm.com>
> ---
> Change-log
> 
> v3:	Use the capp_xscom_write() instead of xscom_write().
> 
> 	Minor change of a branch condition [ Andrew ]
> 
> v2:	Instead of using the 'PHB4_CAPP_REG_OFFSET' macro use the
> 	'struct capp->capp_xscom_offset' member.
> ---

Without going into details, it sounds good. Thanks.

Reviewed-by: Christophe Lombard <clombard at linux.vnet.ibm.com>