[Skiboot] [PATCH 13/13] hw/npu2-common: Allow mixed mode NPU setups
fbarrat at linux.ibm.com
Wed Jan 9 00:26:42 AEDT 2019
Le 12/12/2018 à 07:58, Andrew Donnellan a écrit :
> Now that we have all the support in place for NPUs with both NVLink and
> OpenCAPI devices, get rid of the error that aborts NPU init when a mixed
> setup is detected.
> While we're there, rename setup_devices() to more accurately reflect what
> it does, and move the calls to the NVLink/OpenCAPI setup code out of there
> into the main probe function.
> Signed-off-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>
One very minor detail below
Reviewed-by: Frederic Barrat <fbarrat at linux.ibm.com>
> diff --git a/hw/npu2-opencapi.c b/hw/npu2-opencapi.c
> index a57f556b102d..71661648d8e0 100644
> --- a/hw/npu2-opencapi.c
> +++ b/hw/npu2-opencapi.c
> @@ -19,15 +19,10 @@
> * This file provides support for OpenCAPI as implemented on POWER9.
> - * At present, we initialise the NPU separately from the NVLink code in npu2.c.
> - * As such, we don't currently support mixed NVLink and OpenCAPI configurations
> - * on the same NPU for machines such as Witherspoon.
> - *
> * Procedure references in this file are to the POWER9 OpenCAPI NPU Workbook
> * (IBM internal document).
> * TODO:
> - * - Support for mixed NVLink and OpenCAPI on the same NPU
> * - Support for link ganging (one AFU using multiple links)
> * - Link reset and error handling
> * - Presence detection
Nothing to do with this series, but while we're at it, you can remove
presence detection from that TODO list
More information about the Skiboot