[Skiboot] [PATCH] hw/phb[3/4]: Increase the severity level for pcie slot link timeouts

Stewart Smith stewart at linux.ibm.com
Thu Feb 28 13:50:34 AEDT 2019

Pridhiviraj Paidipeddi <ppaidipe at linux.vnet.ibm.com> writes:
> Currently waiting for PHB pcie slot link timeout error messages
> are in debug log level. Make them to PR_ERR, so that users can
> check in console itself, as well as tests can catch these errors
> easily.
> Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe at linux.vnet.ibm.com>
> ---
>  hw/phb3.c | 4 ++--
>  hw/phb4.c | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> diff --git a/hw/phb3.c b/hw/phb3.c
> index 9bc9d78..b37cf65 100644
> --- a/hw/phb3.c
> +++ b/hw/phb3.c
> @@ -2281,7 +2281,7 @@ static int64_t phb3_poll_link(struct pci_slot *slot)
>  		}
>  		if (slot->retries-- == 0) {
> -			PHBDBG(p, "LINK: Timeout waiting for electrical link\n");
> +			PHBERR(p, "LINK: Timeout waiting for electrical link\n");
>  			PHBDBG(p, "LINK: DLP train control: 0x%016llx\n", reg);
>  			rc = phb3_retry_state(slot);
>  			if (rc >= OPAL_SUCCESS)

(going through really old patches sitting in patchwork and cleaning
things up, and even though Pridhiviraj as left IBM, it's probably good
to follow up publicly)

So, we merged this:

commit e6bca4a0aa985920e985e3a654f4740347ebbf0e
Author: Benjamin Herrenschmidt <benh at kernel.crashing.org>
Date:   Mon Apr 9 13:41:44 2018 +1000

    phb4: Quieten and improve "Timeout waiting for electrical link"
    This happens normally if a slot doesn't have a working HW presence
    detect and relies instead of inband presence detect.
    The message we display is scary and not very useful unless ou
    are debugging, so quiten it up and change it to something more
    Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
    Acked-By: Michael Neuling <mikey at neuling.org>
    Signed-off-by: Stewart Smith <stewart at linux.ibm.com>

Which made things quieter and more accurately reflect the reality of

As such, not going to merge this patch.

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list