[Skiboot] [PATCH 0/2] Enable HIOMAP on P8

Stewart Smith stewart at linux.ibm.com
Tue Feb 26 16:59:28 AEDT 2019

Andrew Jeffery <andrew at aj.id.au> writes:
> I'm back again with enablement patches for hiomap on p8 systems. This time with
> more testing in the loop.
> The bug with bd9839684d48 ("astbmc: Try IPMI HIOMAP for P8") turned out to be
> an issue with ordering of operations in ast_sio_is_enabled(), which broke
> assumptions of ast-sf-ctrl (i.e. that the SuperIO controller was unlocked with
> the correct device selected). Patch 1/2 reworks the test sequence to leave
> SuperIO unlocked with the prior device selected if a device was selected on
> entry to the test.
> Patch 2/2 has not changed from bd9839684d48, aside from being tested on
> Garrison, Palmetto (without and _with_ hiomap) and Witherspoon systems.
> Please review, CI, test and all the other things that we can do to prove I
> haven't broken booting again.

Well, seemed to work on CI I threw at things. So, merged to master as of

My guess is that these should go to stable too (at least once we reckon
everything is okay and not-terrible)?

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list