[Skiboot] [PATCH 1/6] sparse: symbol 'sbe_timer_lock' was not declared. Should it be static?

Stewart Smith stewart at linux.ibm.com
Mon Feb 25 16:24:31 AEDT 2019


Yes, yes it should.

Signed-off-by: Stewart Smith <stewart at linux.ibm.com>
---
 hw/sbe-p9.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/sbe-p9.c b/hw/sbe-p9.c
index d52ada15a39f..c28dbb9d6f08 100644
--- a/hw/sbe-p9.c
+++ b/hw/sbe-p9.c
@@ -1,4 +1,4 @@
-/* Copyright 2017-2018 IBM Corp.
+/* Copyright 2017-2019 IBM Corp.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -91,7 +91,7 @@ static uint64_t sbe_last_gen_stamp;
 static uint64_t sbe_timer_target;
 
 /* Timer lock */
-struct lock sbe_timer_lock;
+static struct lock sbe_timer_lock;
 
 /*
  * Minimum timeout value for P9 is 500 microseconds. After that
-- 
2.20.1



More information about the Skiboot mailing list