[Skiboot] [PATCH 6/6] sparse: symbol '*bar*' was not declared. Should it be static?

Stewart Smith stewart at linux.ibm.com
Mon Feb 25 16:24:36 AEDT 2019


Yes, a bunch of HOMER symbols should be.

Signed-off-by: Stewart Smith <stewart at linux.ibm.com>
---
 hw/homer.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/homer.c b/hw/homer.c
index a0a0733eb806..34ee3370d63f 100644
--- a/hw/homer.c
+++ b/hw/homer.c
@@ -1,4 +1,4 @@
-/* Copyright 2013-2014 IBM Corp.
+/* Copyright 2013-2019 IBM Corp.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -44,8 +44,8 @@ enum P9_BAR {
 	P9_BAR_SBE = 3,
 };
 
-u64 pba_bar0, pba_barmask0;
-u8 bar_homer, bar_slw, bar_occ_common;
+static u64 pba_bar0, pba_barmask0;
+static u8 bar_homer, bar_slw, bar_occ_common;
 
 static bool read_pba_bar(struct proc_chip *chip, unsigned int bar_no,
 			 uint64_t *base, uint64_t *size)
-- 
2.20.1



More information about the Skiboot mailing list