[Skiboot] [PATCH 3/4] hdata/memory: Remove find_shared()

[Vasant Hegde]

On 02/19/2019 01:23 PM, Oliver O'Halloran wrote:
> This helper function is used to check if the node we are about to create
> already exists. There's no real need for this considering we already
> have perfectly functional methods for searching the device-tree, so drop
> it in favour of the more standard dt_find_name_addr().
> 
> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
> ---
>   hdata/memory.c | 43 +++----------------------------------------
>   1 file changed, 3 insertions(+), 40 deletions(-)
>

.../...

>   	chip_id = pcid_to_chip_id(be32_to_cpu(arange->chip));
> 
> @@ -144,18 +113,14 @@ static bool add_address_range(struct dt_node *root,
>   	reg[1] = cleanup_addr(be64_to_cpu(arange->end)) - reg[0];
> 
>   	if (be16_to_cpu(id->flags) & MS_AREA_SHARED) {
> -		/* Only enter shared nodes once. */
> -		mem = find_shared(root, be16_to_cpu(id->share_id),
> -				  reg[0], reg[1]);
> +		mem = dt_find_by_name_addr("memory", reg[0]);


This breaks the compilation.. Of course next patch fixes this issue. But this 
hurts during
git-bisect.

-Vasant