[Skiboot] [PATCH v2 3/3] hw/bt: Do not disable ipmi message retry during OPAL boot

[Andrew Jeffery]

On Fri, 22 Feb 2019, at 02:37, Vasant Hegde wrote:
> Lets not disable IPMI message retry during OPAL boot.

What bug did we encounter? I feel like you could expand a bit more here
on why, though I am lacking a lot of context.

> 
> Fixes: 01f977c3 (hw/bt: Add backend interface to disable ipmi message)
> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> ---
>  core/ipmi.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/core/ipmi.c b/core/ipmi.c
> index 27cb4268f..599d2e97f 100644
> --- a/core/ipmi.c
> +++ b/core/ipmi.c
> @@ -24,6 +24,7 @@
>  #include <lock.h>
>  #include <cpu.h>
>  #include <timebase.h>
> +#include <debug_descriptor.h>
>  
>  struct ipmi_backend *ipmi_backend = NULL;
>  static struct lock sync_lock = LOCK_UNLOCKED;
> @@ -176,7 +177,7 @@ void ipmi_queue_msg_sync(struct ipmi_msg *msg)
>  	lock(&sync_lock);
>  	while (sync_msg);
>  	sync_msg = msg;
> -	if (msg->backend->disable_retry)
> +	if (msg->backend->disable_retry && !opal_booting())
>  		msg->backend->disable_retry(msg);
>  	ipmi_queue_msg_head(msg);
>  	unlock(&sync_lock);
> -- 
> 2.14.3
> 
> _______________________________________________
> Skiboot mailing list
> Skiboot at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot
>