[Skiboot] [PATCH v2 13/52] libflash/ipmi-hiomap: Remove unused close handling
Andrew Jeffery
andrew at aj.id.au
Thu Feb 21 17:28:12 AEDT 2019
Issuing a HIOMAP_C_CLOSE is not required by the protocol specification,
rather a close can be implicit in a subsequent
CREATE_{READ,WRITE}_WINDOW request. The implicit close provides an
opportunity to reduce LPC traffic and the implementation takes up that
optimisation, so remove the case from the IPMI callback handler.
Cc: stable
Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
---
libflash/ipmi-hiomap.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/libflash/ipmi-hiomap.c b/libflash/ipmi-hiomap.c
index fdd12d5754e2..7a36449a5d0b 100644
--- a/libflash/ipmi-hiomap.c
+++ b/libflash/ipmi-hiomap.c
@@ -204,11 +204,6 @@ static void ipmi_hiomap_cmd_cb(struct ipmi_msg *msg)
break;
}
- case HIOMAP_C_CLOSE_WINDOW:
- lock(&ctx->lock);
- ctx->window_state = closed_window;
- unlock(&ctx->lock);
- break;
case HIOMAP_C_MARK_DIRTY:
case HIOMAP_C_FLUSH:
case HIOMAP_C_ACK:
--
2.19.1
More information about the Skiboot
mailing list