[Skiboot] [PATCH 0/2] Enable HIOMAP on P8

Andrew Jeffery andrew at aj.id.au
Thu Feb 21 15:50:21 AEDT 2019


I'm back again with enablement patches for hiomap on p8 systems. This time with
more testing in the loop.

The bug with bd9839684d48 ("astbmc: Try IPMI HIOMAP for P8") turned out to be
an issue with ordering of operations in ast_sio_is_enabled(), which broke
assumptions of ast-sf-ctrl (i.e. that the SuperIO controller was unlocked with
the correct device selected). Patch 1/2 reworks the test sequence to leave
SuperIO unlocked with the prior device selected if a device was selected on
entry to the test.

Patch 2/2 has not changed from bd9839684d48, aside from being tested on
Garrison, Palmetto (without and _with_ hiomap) and Witherspoon systems.

Please review, CI, test and all the other things that we can do to prove I
haven't broken booting again.



Andrew Jeffery (2):
  ast-io: Rework ast_sio_is_enabled() test sequence
  astbmc: Try IPMI HIOMAP for P8 (again)

 hw/ast-bmc/ast-io.c       | 46 +++++++++++++++++++++++++--------
 include/ast.h             |  3 ++-
 platforms/astbmc/common.c | 36 +++++++++++++++++++++-----
 platforms/astbmc/pnor.c   | 54 ++++++++++++++++++++++-----------------
 4 files changed, 97 insertions(+), 42 deletions(-)


More information about the Skiboot mailing list