[Skiboot] [PATCH skiboot v2] opal: Deprecate reading the PHB status
stewart at linux.ibm.com
Tue Feb 19 15:50:14 AEDT 2019
Alexey Kardashevskiy <aik at ozlabs.ru> writes:
> The OPAL_PCI_EEH_FREEZE_STATUS call takes a bunch of parameters, one of
> them is @phb_status. It is defined as __be64* and always NULL in
> the current Linux upstream but if anyone ever decides to read that status,
> then the PHB3's handler will assume it is struct OpalIoPhb3ErrorData*
> (which is a lot bigger than 8 bytes) and zero it causing the stack
> corruption; p7ioc-phb has the same issue.
> This removes @phb_status from all eeh_freeze_status() hooks and moves
> the error message from PHB4 to the affected OPAL handlers.
> Signed-off-by: Alexey Kardashevskiy <aik at ozlabs.ru>
Merged to master as of fd0950488f7f2c34e921888f69e76d75498078f2.
I don't really have a "this is how we deprecate things", although maybe
I should? Since it's been effectively unused pretty much since the
beginning of time, we're probably safe here.
OPAL Architect, IBM.
More information about the Skiboot