[Skiboot] [PATCH] platforms/witherspoon: Make PCIe shared slot error message more informative

Stewart Smith stewart at linux.ibm.com
Tue Feb 19 14:19:13 AEDT 2019


Andrew Donnellan <andrew.donnellan at au1.ibm.com> writes:
> If we're missing chips for some reason, we print a warning when configuring
> the PCIe shared slot.
>
> The warning doesn't really make it clear what "shared slot" is, and if it's
> printed, it'll come right after a bunch of messages about NPU setup, so
> let's clarify the message to explicitly mention PCI.
>
> Signed-off-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>
> ---
>  platforms/astbmc/witherspoon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/platforms/astbmc/witherspoon.c b/platforms/astbmc/witherspoon.c
> index fe138991696f..0fafc87eb4c6 100644
> --- a/platforms/astbmc/witherspoon.c
> +++ b/platforms/astbmc/witherspoon.c
> @@ -184,7 +184,7 @@ static void witherspoon_shared_slot_fixup(void)
>  	chip1 = next_chip(chip0);
>  	if (!chip1 || next_chip(chip1)) {
>  		prlog(PR_WARNING,
> -			"Unexpected number of chips, skipping shared slot detection\n");
> +			"PLAT: Unexpected number of chips, skipping PCIe shared slot detection\n");
>  		return;
>  	}

After much bikeshedding and procrastination on my part... I'm not sure
what would really be an improvement here.. but I AM GOING TO BIKESHED
THIS A BIT MORE.

going with this:
      "PLAT: Can't find second chip, "
      "skipping PCIe shared slot detection\n");


-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list