[Skiboot] [PATCH 01/51] stubs: Remove __attrconst annotation

Stewart Smith stewart at linux.ibm.com
Mon Feb 18 11:58:26 AEDT 2019


Andrew Jeffery <andrew at aj.id.au> writes:
> `make check` with gcc 8.2.0 (Ubuntu 8.2.0-7ubuntu1) produces the
> following warnings:
>
>     [ HOSTCC ]  core/test/stubs.c
>     core/test/stubs.c:80:1: warning: ‘const’ attribute on function returning
>     ‘void’ [-Wattributes]
>     {

As discussed in chat, I'm not convinced the could-be-const attribute
warning isn't just a pain in the arse that seems to vary based on GCC
version so much that having it be Werror is just a source of pain.

Maybe have it no-error or something?

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list