[Skiboot] [PATCH v2 10/15] hw/npu2: Combined NPU brick configuration procedure
andrew.donnellan at au1.ibm.com
Fri Feb 8 15:01:15 AEDT 2019
On 1/2/19 3:52 pm, Alexey Kardashevskiy wrote:
> On 31/01/2019 15:39, Andrew Donnellan wrote:
>> On 21/1/19 5:18 pm, Alexey Kardashevskiy wrote:
>>> On 11/01/2019 12:09, Andrew Donnellan wrote:
>>>> To support the case where we have both OpenCAPI and NVLink devices
>>>> connected to the same NPU, we need to be able to configure each NPU
>>>> stack/brick separately depending on the device type it is connected to.
>>>> Refactor the existing code so that we can set the transport muxes and
>>>> relevant NPU registers on a per-brick/stack basis. Replace the existing
>>>> hard-coded register values for NVLink setup with code to do it properly
>>>> only on the devices that need it.
>>> This "replace" is in fact obfuscation of the actual change :( Frederic
>>> must be a superman to have this reviewed :)
>> "Replace" is a fairly accurate description IMHO. :)
> If it all happened within the same npu2_nvlink_init_npu() - suuuure.
> Or ok, npu2_nvlink_init_npu() and enable_nvlink(), to avoid moving
> chunks again in the same patchset. But other changes seems unrelated.
I think I can split apart the npu2.c bits, so I'll move them to a
separate earlier patch.
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com IBM Australia Limited
More information about the Skiboot