[Skiboot] [PATCH] doc: Adjusting tags in release notes to eliminate global conflict

Andrew Donnellan andrew.donnellan at au1.ibm.com
Wed Feb 6 10:07:19 AEDT 2019

On 6/2/19 4:50 am, Jeff Scheel wrote:
> Vasant, I'm not sure what you mean by "add comments".  The tags are 
> self-consistent in the document in that they are defined and referenced 
> all in the same file.

The change should be described in the commit message to explain what the 
issue is - generally skiboot (+ Linux kernel) patches are required to 
use the first line of the commit message as a "summary", and then at 
least a sentence or two explaining in more detail what the change is.


> If your question is what file also contains the conflicting tags, they 
> are in skiboot-5.7.rst.  I'll plead ignorance as to how these files are 
> created, but they almost appear to be copy & paste errors between the 
> two files.  If the project is going to support build modes such as 
> "singlehtml" for documentation, these labels need to be unique.
> Hope that answers your question.
> -Jeff
> On Tue, Feb 5, 2019 at 8:54 AM Vasant Hegde 
> <hegdevasant at linux.vnet.ibm.com <mailto:hegdevasant at linux.vnet.ibm.com>> 
> wrote:
>     On 02/05/2019 06:56 PM, Jeff Scheel wrote:
>      > Signed-off-by: Jeff Scheel <scheel at us.ibm.com
>     <mailto:scheel at us.ibm.com>>
>     Can you please add small description about the conflict.. so that it
>     makes easy
>     to review.
>     -Vasant
> _______________________________________________
> Skiboot mailing list
> Skiboot at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot

Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited

More information about the Skiboot mailing list