[Skiboot] [PATCH v2 02/15] hw/npu2: Merge implementations of BAR accessor functions

Andrew Donnellan andrew.donnellan at au1.ibm.com
Fri Feb 1 15:57:22 AEDT 2019

On 1/2/19 3:44 pm, Alexey Kardashevskiy wrote:
>>> Here you add type/index/reg/enabled initialization, not move from
>>> elsewhere so there either was a bug with unitialized bar struct or now
>>> we have 2 places where such initialization occurs. The commit log does
>>> not mentioned this. I am confused.
>> Previously those fields weren't used at all, we only used base and size.
>> Now that we're merging the BAR accessor functions, we need to populate
>> those fields because we're using the shared functions npu2_get_bar() and
>> npu2_write_bar(), rather than open-coding phys_map_get() and having an
>> OpenCAPI-only function called write_bar() that took the reg directly as
>> an argument.
>> This code all disappears in a later patch.
> This tells us that either this later patch should be squashed into this
> one or it should move before this one.

Hang on, I thought patch #4 was the one that was too complex and needed 
to be split out more :)

Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited

More information about the Skiboot mailing list