[Skiboot] [PATCH] stable/build: Do not convert warnings to error
hegdevasant at linux.vnet.ibm.com
Thu Dec 12 16:33:34 AEDT 2019
On 12/12/19 12:31 AM, Dan Horák wrote:
> On Wed, 11 Dec 2019 16:59:02 +0530
> Vasant Hegde <hegdevasant at linux.vnet.ibm.com> wrote:
>>> this expects building from git checkout, but will have issues when
>>> building from the released source archive
>> Oh yeah. I missed that. how about this?
> yes, this should work. The only question is whether it's better to use
> "0" or "1" for describing the "found" state. My preference would be to
> use "1". I guess it's "return code" vs. "logic value".
> GIT_DIR ?= $(shell test -e $(SRC)/.git && echo 1 || echo 0
> ifeq ($(GIT_DIR),1) # means $(SRC)/.git exists ...
> looks more readable to me and also in line with the existing logic in
Makes sense. Will fix it in v2.
More information about the Skiboot