[Skiboot] [PATCH 1/2] fast-reboot: don't back up old vectors upon fast reboot

[Nicholas Piggin]

Oliver O'Halloran's on December 10, 2019 10:01 am:
> On Mon, Dec 9, 2019 at 9:50 PM Nicholas Piggin <npiggin at gmail.com> wrote:
>>
>> Initial boot already saved original exception vectors to old_vectors,
>> copying again upon fast reboot will overwrite old_vectors with some
>> arbitrary vectors set up by the current OS.
> 
> What's this even needed for? Re-entering the previously booted kernel
> image seems fundamentally sketch and we re-load the kernel anyway. The
> only thing I can think of is fast-rebooting in mambo and I'm not sure
> it'll work there either.

Yeah I'm not too sure. Whatever it was for is definitely broken with
fast reboot. Fast reboot with a kernel at zero might still be broken
for other reasons, but it won't be for this at least :P

Thanks,
Nick