[Skiboot] [PATCH 5/7] crypto: add out-of-tree mbedtls pkcs7 parser

[Nayna]

On 12/4/19 10:59 AM, Stewart Smith wrote:
> On Tue, Dec 3, 2019, at 4:06 PM, Eric Richter wrote:
>> From: Nayna Jain <nayna at linux.ibm.com>
>>
>> This patch adds a pkcs7 parser for mbedtls that hasn't yet
>> gone upstream. Once/if that implementation is accepted,
>> this patch can be removed.
>>
>> Signed-off-by: Eric Richter <erichte at linux.ibm.com>
>> ---
>>   libstb/crypto/Makefile.inc       |   4 +-
>>   libstb/crypto/pkcs7/Makefile.inc |  10 +
>>   libstb/crypto/pkcs7/pkcs7.c      | 476 +++++++++++++++++++++++++++++++
>>   libstb/crypto/pkcs7/pkcs7.h      | 176 ++++++++++++
>>   4 files changed, 665 insertions(+), 1 deletion(-)
>>   create mode 100644 libstb/crypto/pkcs7/Makefile.inc
>>   create mode 100644 libstb/crypto/pkcs7/pkcs7.c
>>   create mode 100644 libstb/crypto/pkcs7/pkcs7.h
> What's the testing story for this code?

The pkcs7 support is implemented on top of base mbedtls 
(https://github.com/naynajain/mbedtls/tree/mbedtls-2.16) which is forked 
from repo -  https://github.com/ARMmbed/mbedtls  (2.16.0)

The patch is created from the pkcs7 commit in this branch - 
https://github.com/naynajain/mbedtls/tree/mbedtls-2.16-pkcs7-recover

The corresponding test suites are in ./tests/suites directory.

There are also backend driver test cases in [Patch 6/7] which is 
actually the consumer of pkcs7 parser and verifier.

Thanks & Regards,

      - Nayna