[Skiboot] [PATCH] Move sbin commands manpages from section 1 to 8

Dan Horák dan at danny.cz
Fri Aug 23 17:53:28 AEST 2019


On Wed, 21 Aug 2019 18:09:23 +0200
Frédéric Bonnard <frediz at debian.org> wrote:

> Following Debian's lintian suggestion :
> https://lintian.debian.org/tags/command-in-sbin-has-manpage-in-incorrect-section.html
> 
> "The command in /sbin or /usr/sbin are system administration commands;
> their manpages thus belong in section 8, not section 1.
> 
> Please check whether the command is actually useful to non-privileged
> user in which case it should be moved to /bin or /usr/bin, or
> alternatively the manual page should be moved to section 8 instead,
> ie. /usr/share/man/man8."
> 
> Those commands are, I suppose, in the right directory according to
> what their usage is. So I changed the section of their manpage to
> section 8.
> 
> Signed-off-by: Frédéric Bonnard <frediz at debian.org>

LGTM, but the question also is, whether (all?) the tools couldn't be
moved into "bin" instead.


		Dan

> ---
>  external/gard/{opal-gard.1 => opal-gard.8}    | 2 +-
>  external/gard/rules.mk                        | 2 +-
>  external/pflash/Makefile                      | 2 +-
>  external/pflash/{pflash.1 => pflash.8}        | 2 +-
>  external/xscom-utils/Makefile                 | 6 +++---
>  external/xscom-utils/{getscom.1 => getscom.8} | 2 +-
>  external/xscom-utils/{getsram.1 => getsram.8} | 2 +-
>  external/xscom-utils/{putscom.1 => putscom.8} | 2 +-
>  8 files changed, 10 insertions(+), 10 deletions(-)
>  rename external/gard/{opal-gard.1 => opal-gard.8} (96%)
>  rename external/pflash/{pflash.1 => pflash.8} (99%)
>  rename external/xscom-utils/{getscom.1 => getscom.8} (94%)
>  rename external/xscom-utils/{getsram.1 => getsram.8} (94%)
>  rename external/xscom-utils/{putscom.1 => putscom.8} (93%)
> 
> diff --git a/external/gard/opal-gard.1 b/external/gard/opal-gard.8
> similarity index 96%
> rename from external/gard/opal-gard.1
> rename to external/gard/opal-gard.8
> index 65b21447..e1f36431 100644
> --- a/external/gard/opal-gard.1
> +++ b/external/gard/opal-gard.8
> @@ -1,4 +1,4 @@
> -.TH opal-gard 1 "19 June 2015"
> +.TH opal-gard 8 "19 June 2015"
>  .SH NAME
>  opal-gard \- GUARD Partition manipulation tool for OpenPower hardware
>  .SH SYNOPSIS
> diff --git a/external/gard/rules.mk b/external/gard/rules.mk
> index 8db66b88..ffb19051 100644
> --- a/external/gard/rules.mk
> +++ b/external/gard/rules.mk
> @@ -46,6 +46,6 @@ $(EXE): $(OBJS)
>  
>  install: all
>  	install -D $(EXE) $(DESTDIR)$(sbindir)/$(EXE)
> -	install -D -m 0644 $(EXE).1 $(DESTDIR)$(mandir)/man1/$(EXE).1
> +	install -D -m 0644 $(EXE).8 $(DESTDIR)$(mandir)/man8/$(EXE).8
>  
>  
> diff --git a/external/pflash/Makefile b/external/pflash/Makefile
> index 2918b7c3..216f4714 100644
> --- a/external/pflash/Makefile
> +++ b/external/pflash/Makefile
> @@ -25,7 +25,7 @@ check: version.o all
>  
>  install: all $(INSTALLDEPS)
>  	install -D pflash $(DESTDIR)$(sbindir)/pflash
> -	install -D -m 0644 pflash.1 $(DESTDIR)$(mandir)/man1/pflash.1
> +	install -D -m 0644 pflash.8 $(DESTDIR)$(mandir)/man8/pflash.8
>  
>  .PHONY: dist
>  #File is named $(PFLASH_VERSION).tar because the expectation is that
>  #pflash-
> diff --git a/external/pflash/pflash.1 b/external/pflash/pflash.8
> similarity index 99%
> rename from external/pflash/pflash.1
> rename to external/pflash/pflash.8
> index 5db8d460..f3b44e53 100644
> --- a/external/pflash/pflash.1
> +++ b/external/pflash/pflash.8
> @@ -1,4 +1,4 @@
> -.TH pflash "1" "September 2016"
> +.TH pflash "8" "September 2016"
>  .SH NAME
>  pflash \- manual page for Open-Power Flash tool
>  .SH SYNOPSIS
> diff --git a/external/xscom-utils/Makefile
> b/external/xscom-utils/Makefile index b0b10891..574d5c81 100644
> --- a/external/xscom-utils/Makefile
> +++ b/external/xscom-utils/Makefile
> @@ -35,9 +35,9 @@ install: all
>  	install -D getscom $(DESTDIR)$(sbindir)/getscom
>  	install -D putscom $(DESTDIR)$(sbindir)/putscom
>  	install -D getsram $(DESTDIR)$(sbindir)/getsram
> -	install -D -m 0644 getscom.1 $(DESTDIR)$
> (mandir)/man1/getscom.1
> -	install -D -m 0644 putscom.1 $(DESTDIR)$
> (mandir)/man1/putscom.1
> -	install -D -m 0644 getsram.1 $(DESTDIR)$
> (mandir)/man1/getsram.1
> +	install -D -m 0644 getscom.8 $(DESTDIR)$
> (mandir)/man8/getscom.8
> +	install -D -m 0644 putscom.8 $(DESTDIR)$
> (mandir)/man8/putscom.8
> +	install -D -m 0644 getsram.8 $(DESTDIR)$
> (mandir)/man8/getsram.8 
>  .PHONY: clean
>  clean:
> diff --git a/external/xscom-utils/getscom.1
> b/external/xscom-utils/getscom.8 similarity index 94%
> rename from external/xscom-utils/getscom.1
> rename to external/xscom-utils/getscom.8
> index 295b99d5..1de51a9f 100644
> --- a/external/xscom-utils/getscom.1
> +++ b/external/xscom-utils/getscom.8
> @@ -1,4 +1,4 @@
> -.TH XSCOM "1" "September 2016"
> +.TH XSCOM "8" "September 2016"
>  .SH NAME
>  getscom \- part of xscom utils
>  .SH SYNOPIS
> diff --git a/external/xscom-utils/getsram.1
> b/external/xscom-utils/getsram.8 similarity index 94%
> rename from external/xscom-utils/getsram.1
> rename to external/xscom-utils/getsram.8
> index 19b29741..023b1259 100644
> --- a/external/xscom-utils/getsram.1
> +++ b/external/xscom-utils/getsram.8
> @@ -1,4 +1,4 @@
> -.TH XSCOM "1" "January 2018"
> +.TH XSCOM "8" "January 2018"
>  .SH NAME
>  getsram \- part of xscom utils
>  .SH SYNOPIS
> diff --git a/external/xscom-utils/putscom.1
> b/external/xscom-utils/putscom.8 similarity index 93%
> rename from external/xscom-utils/putscom.1
> rename to external/xscom-utils/putscom.8
> index 9c329fc2..89e8bdf4 100644
> --- a/external/xscom-utils/putscom.1
> +++ b/external/xscom-utils/putscom.8
> @@ -1,4 +1,4 @@
> -.TH XSCOM "1" "September 2016"
> +.TH XSCOM "8" "September 2016"
>  .SH NAME
>  putscom \- part of xscom utils
>  .SH SYNOPIS
> -- 
> 2.20.1
> 


More information about the Skiboot mailing list