[Skiboot] [PATCH] Use file operation used on x86 for ARCH_UNKNOWN

[Oliver O'Halloran]

On Fri, Aug 23, 2019 at 11:49 AM Frédéric Bonnard <frederic at fr.ibm.com> wrote:
>
> On arches where only file operation make sense such as x86 and others, use the same
> code.


Hi Frédéric

Thanks for the patch. The change itself makes sense, but you'll need
to add a Signed-off-by line and we generally attach a subsystem prefix
to the patch title. "external/common: " would probably be appropriate
here.

Just FYI I've had to manually approve the last few mails you've sent
to the list. If you're doing to be doing more work on skiboot then you
should subscribe to the list so your messages don't get put into the
moderation queue. You can subscribe using the form here:
https://lists.ozlabs.org/listinfo/skiboot

Also, the IBM email infrastructure is well known for mangling patches.
It seems to have worked out ok in this case, but you might want to get
a @linux.ibm.com address for community facing work. That's not
required though, I don't really mind what provider people use as long
as it sends patches correctly.

Thanks,
Oliver

> ---
>  .../common/{arch_flash_x86.c => arch_flash_unknown.c}     | 0
>  .../{arch_flash_x86_io.h => arch_flash_unknown_io.h}      | 0
>  external/common/get_arch.sh                               | 2 --
>  external/common/rules.mk                                  | 8 ++------
>  4 files changed, 2 insertions(+), 8 deletions(-)
>  rename external/common/{arch_flash_x86.c => arch_flash_unknown.c} (100%)
>  rename external/common/{arch_flash_x86_io.h => arch_flash_unknown_io.h} (100%)
>
> diff --git a/external/common/arch_flash_x86.c b/external/common/arch_flash_unknown.c
> similarity index 100%
> rename from external/common/arch_flash_x86.c
> rename to external/common/arch_flash_unknown.c
> diff --git a/external/common/arch_flash_x86_io.h b/external/common/arch_flash_unknown_io.h
> similarity index 100%
> rename from external/common/arch_flash_x86_io.h
> rename to external/common/arch_flash_unknown_io.h
> diff --git a/external/common/get_arch.sh b/external/common/get_arch.sh
> index b5e0867e..1e2d375e 100755
> --- a/external/common/get_arch.sh
> +++ b/external/common/get_arch.sh
> @@ -3,8 +3,6 @@
>
>  echo "#if defined(__powerpc__)
>  echo -n ARCH_POWERPC
> -#elif defined(__x86_64__) || defined(__i386__)
> -echo -n ARCH_X86
>  #elif defined(__arm__)
>  echo -n ARCH_ARM
>  #else
> diff --git a/external/common/rules.mk b/external/common/rules.mk
> index 05eb755f..7190813b 100644
> --- a/external/common/rules.mk
> +++ b/external/common/rules.mk
> @@ -12,12 +12,8 @@ ifeq ($(ARCH),ARCH_POWERPC)
>  arch := powerpc
>  ARCH_FILES := arch_flash_common.c arch_flash_powerpc.c
>  else
> -ifeq ($(ARCH),ARCH_X86)
> -arch := x86
> -ARCH_FILES := arch_flash_common.c arch_flash_x86.c
> -else
> -$(error Unsupported architecture $(ARCH))
> -endif
> +arch := unknown
> +ARCH_FILES := arch_flash_common.c arch_flash_unknown.c
>  endif
>  endif
>
> --
> 2.20.1
>
> _______________________________________________
> Skiboot mailing list
> Skiboot at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot