[Skiboot] [PATCH v2 4/4] npu3: Register virtual PHBs with static IDs

[Frederic Barrat]

Le 12/08/2019 à 23:28, Reza Arbab a écrit :
> On Fri, Aug 09, 2019 at 03:05:34PM +0200, Frederic Barrat wrote:
>> --- a/include/phb4.h
>> +++ b/include/phb4.h
>> @@ -245,10 +245,15 @@ static inline void phb4_set_err_pending(struct 
>> phb4 *p, bool pending)
>> }
>>
>> #define PHB4_PER_CHIP                        6 /* Max 6 PHBs per chip 
>> on p9 */
>> +#define PHB4_MAX_PHBS_PER_CHIP_P9            PHB4_PER_CHIP
>> +#define PHB4_MAX_PHBS_PER_CHIP_P9P           0x10 /* extra for virt 
>> PHBs */
> 
> Minor nit; why in hex? 16 instead of 0x10 seems more consistent. Otherwise,

No real reasons, other than lspci showing domains in hex. I don't really 
care.

   Fred

> 
> Reviewed-by: Reza Arbab <arbab at linux.ibm.com>
>