[Skiboot] [PATCH] npu: Fix device binding error message

Oliver O'Halloran oohall at gmail.com
Thu Aug 8 23:41:15 AEST 2019


On Thu, Aug 8, 2019 at 5:36 PM Alexey Kardashevskiy <aik at ozlabs.ru> wrote:
>
> I wanted to suggest using PCI_BUS_NUM/PCI_SLOT/PCI_FUNC instead and then
> realized that skiboot simply does not have these or similar (copied from
> qemu):
>
> #define PCI_BUS_NUM(x)          (((x) >> 8) & 0xff)
> #define PCI_SLOT(devfn)         (((devfn) >> 3) & 0x1f)
> #define PCI_FUNC(devfn)         ((devfn) & 0x07)
>
> Oh well, the patch is absolutely correct then

I wouldn't complain if someone added those.


More information about the Skiboot mailing list