[Skiboot] [PATCH] core/opal: Fix address-cells in opal node in DT

Maxim Polyakov m.polyakov at yadro.com
Wed Apr 24 21:56:32 AEST 2019

19.04.2019 11:59, Vasant Hegde пишет:
> On 04/15/2019 07:41 PM, Jeremy Kerr wrote:
>> Hi all,
>>>> This patch fix this FWTS warning:
>>>> Warning (reg_format): "reg" property in /ibm,opal/flash at 0 has
>>>> invalid length (8 bytes) (#address-cells == 0, #size-cells == 0)
>> This is a bit of a tricky one. The ibm,opal node doesn't reference a
>> "bus" of any kind, so the #address-cells and #size-cells being zero is
>> correct. What we should have done for the flash node is used some
>> property (other than 'reg', which has a specific meaning) for the size
>> of the flash device.
>> However, even if we patches that in OPAL and Linux now, renaming the
>> property would break compatibility with existing OSes.
>>> But if we add "#size-cells" = 1 then its like telling you have `size`
>>> without address.. which is also wrong.
>> That's not too much of an issue; the implication that this introduces is
>> that any 'reg' node under /ibm,opal is a one-cell size value - which may
>> not be too bad a thing.
>>> May be we can just add this patch to keep dtc happy.
>>> @jk, any thoughts?
>> It's not great, but it's probably not too awful either. Silencing the
>> warning might be a reasonable justification here, and it could be argued
>> that nodes under ibm,opal could reasonably describe sizes of things?
> Agree. Lets add size property as "1" and silence warning.
> @Maxim, Can you respin the patch? And fat comment explaining the rational behind this fix.

I updated the patch in https://patchwork.ozlabs.org/patch/1090093/

> -Vasant

Maxim Polyakov 
Software Engineer, YADRO.

More information about the Skiboot mailing list