[Skiboot] [PATCH] cpufeatures: Add tm-suspend-hypervisor-assist and tm-suspend-xer-so-bug node

Stewart Smith stewart at linux.ibm.com
Fri Apr 12 11:02:24 AEST 2019


Paul Mackerras <paulus at ozlabs.org> writes:
> On Mon, Apr 08, 2019 at 02:16:54PM +1000, Stewart Smith wrote:
>> Stewart Smith <stewart at linux.ibm.com> writes:
>> 
>> > tm-suspend-hypervisor-assist for P9 >=DD2.2
>> > And a tm-suspend-xer-so-bug node for P9 DD2.2 only.
>> >
>> > I also treat P9P as P9 DD2.3 and add a unit test for the cpufeatures
>> > infrastructure.
>
>> > +	{ "tm-suspend-hypervisor-assist",
>> > +	CPU_P9_DD2_2|CPU_P9_DD2_3|CPU_P9P,
>> > +	ISA_V3_0B, USABLE_HV|USABLE_OS,
>> 
>> After chatting with Nick quickly on Slack, he suggests dropping the
>> USABLE_OS.
>
> That seems right.
>
>> Another option raised was to also use `errata-` as a prefix for
>> these. Thoughts from the gallery?
>
> I'd prefer not, because existing kernels are looking for the
> "tm-suspend-hypervisor-assist" and "tm-suspend-xer-so-bug" names.

Yeah, I think it might be something for future errata-type "features".

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list