[Skiboot] [PATCH v2 1/5] libflash/ipmi-hiomap: Fix blocks count issue

Stewart Smith stewart at linux.ibm.com
Thu Apr 11 14:53:10 AEST 2019

"Andrew Jeffery" <andrew at aj.id.au> writes:
> On Mon, 8 Apr 2019, at 15:35, Vasant Hegde wrote:
>> We convert data size to block count and pass block count to BMC.
>> If data size is not block aligned then we endup sending block count
>> less than actual data. BMC will write partial data to flash memory.
>> Sample log :
>> [  594.388458416,7] HIOMAP: Marked flash dirty at 0x42010 for 8
>> [  594.398756487,7] HIOMAP: Flushed writes
>> [  594.409596439,7] HIOMAP: Marked flash dirty at 0x42018 for 3970
>> [  594.419897507,7] HIOMAP: Flushed writes
>> In this case HIOMAP sent data with block count=0 and hence BMC didn't
>> flush data to flash.
>> Lets fix this issue by adjusting block count before sending it to BMC.
>> Cc: Andrew Jeffery <andrew at aj.id.au>
>> Cc: skiboot-stable at lists.ozlabs.org
>> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> Reviewed-by: Andrew Jeffery <andrew at aj.id.au>
> Thanks for cleaning up my mess :)

Pretty amazing we missed having tests for this kind of thing for so

Series merged to master as of 857f046d3ab00ec12dcb06ddabfed6bdfe00a819

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list