[Skiboot] [PATCH] cpufeatures: Add tm-suspend-hypervisor-assist and tm-suspend-xer-so-bug node

Nicholas Piggin npiggin at gmail.com
Tue Apr 9 19:05:12 AEST 2019


Stewart Smith's on April 8, 2019 2:16 pm:
> Stewart Smith <stewart at linux.ibm.com> writes:
> 
>> @@ -721,6 +725,39 @@ static const struct cpu_feature cpu_features_table[] = {
>>  	HV_NONE, OS_NONE,
>>  	-1, -1, -1,
>>  	NULL, },
>> +
>> +	/*
>> +	 * Due to hardware bugs in POWER9, the hypervisor needs to assist
>> +	 * guests.
>> +	 *
>> +	 * Presence of this feature indicates presence of the bug.
>> +	 *
>> +	 * See linux kernel commit 4bb3c7a0208f
>> +	 * and linux Documentation/powerpc/transactional_memory.txt
>> +	 */
>> +	{ "tm-suspend-hypervisor-assist",
>> +	CPU_P9_DD2_2|CPU_P9_DD2_3|CPU_P9P,
>> +	ISA_V3_0B, USABLE_HV|USABLE_OS,
> 
> After chatting with Nick quickly on Slack, he suggests dropping the
> USABLE_OS.
> 
> Another option raised was to also use `errata-` as a prefix for
> these. Thoughts from the gallery?

Technically it makes no difference of course. I would like to add it
as it gives more information to the name, and generally the rest of
the features are positive (certain facility exists) rather than
negative.

Thanks,
Nick



More information about the Skiboot mailing list