[Skiboot] [PATCH v3 7/7] opal/hmi: Never trust a cow!

Frederic Barrat fbarrat at linux.ibm.com
Sat Apr 6 01:33:04 AEDT 2019

With opencapi, it's fairly common to trigger HMIs during AFU
development on the FPGA, by not replying in time to an NPU command,
for example. So shift the blame reported by that cow to avoid crowding
my mailbox.

Signed-off-by: Frederic Barrat <fbarrat at linux.ibm.com>

Dear Stewart: I'm impressed by your willingness to fight for the
bovine cultural identity. However, it makes my life hard. I therefore
plead for you to consider this patch. Truth is, NPUs in mixed mode
(opencapi and nvlink) are unlikely to become the norm, so cows can
keep symbolizing (mostly) your favorite graphics card manufacturer.
In a later patch, for platforms where we only have opencapi, we could
switch animal. But it is hard to draw a capybara in ascii!

v2, v3: no change

 core/hmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/hmi.c b/core/hmi.c
index 26277fa6..6a391ec4 100644
--- a/core/hmi.c
+++ b/core/hmi.c
@@ -679,7 +679,7 @@ static void find_npu2_checkstop_reason(int flat_chip_id,
 	if (npu2_hmi_verbose) {
 		prlog(PR_ERR, " _________________________ \n");
-		prlog(PR_ERR, "< It's Driver Debug time! >\n");
+		prlog(PR_ERR, "<    It's Debug time!     >\n");
 		prlog(PR_ERR, " ------------------------- \n");
 		prlog(PR_ERR, "       \\   ,__,            \n");
 		prlog(PR_ERR, "        \\  (oo)____        \n");

More information about the Skiboot mailing list