[Skiboot] [PATCH] cpufeatures: Add tm-suspend-hypervisor-assist and tm-suspend-xer-so-bug node

[Vaidyanathan Srinivasan]

* Michael Neuling <mikey at neuling.org> [2019-04-04 17:30:38]:

> On Wed, 2019-04-03 at 16:48 +1100, Stewart Smith wrote:
> > tm-suspend-hypervisor-assist for P9 >=DD2.2
> > And a tm-suspend-xer-so-bug node for P9 DD2.2 only.
> > 
> > I also treat P9P as P9 DD2.3 and add a unit test for the cpufeatures
> > infrastructure.
> > 
> > Fixes: https://github.com/open-power/skiboot/issues/233
> > Suggested-by: Paul Mackerras <paulus at ozlabs.org>
> > Signed-off-by: Stewart Smith <stewart at linux.ibm.com>
> 
> Tested-by: Michael Neuling <mikey at neuling.org>
> 
> FWIW, tested in mambo by playing with the PVR and looking at what cpu features
> bits get set in the early kernel boot log. Checked 2.1, 2.2 and 2.3 did what was
> expected.

Reviewed-by: Vaidyanathan Srinivasan <svaidy at linux.vnet.ibm.com>
Tested-by: Vaidyanathan Srinivasan <svaidy at linux.vnet.ibm.com>

The patch added the right flag as expected.  I tested on DD2.2 and
DD2.3 P9 hardware.

P9 DD2.3: Has only the tm-suspend-hypervisor-assist flag

# lsprop /proc/device-tree/cpus/ibm,powerpc-cpu-features/tm-suspend-hypervisor-assist/
isa              00000bb8 (3000)
hv-support       00000000
phandle          0000015d (349)
usable-privilege 00000006
name             "tm-suspend-hypervisor-assist"

P9 DD2.2: Has both the flags.

#  lsprop /proc/device-tree/cpus/ibm,powerpc-cpu-features/tm-suspend-hypervisor-assist/
isa              00000bb8 (3000)
hv-support       00000000
phandle          0000015d (349)
usable-privilege 00000006
name             "tm-suspend-hypervisor-assist"

#  lsprop /proc/device-tree/cpus/ibm,powerpc-cpu-features/tm-suspend-xer-so-bug/
isa              00000bb8 (3000)
hv-support       00000000
phandle          0000015e (350)
usable-privilege 00000004
name             "tm-suspend-xer-so-bug"

--Vaidy