[Skiboot] [PATCH] phb4: Generate checkstop on AIB ECC corr/uncorr for DD2.0 parts

Michael Neuling mikey at neuling.org
Fri Sep 28 10:41:53 AEST 2018


On Thu, 2018-09-27 at 09:16 +0200, Stewart Smith wrote:
> Michael Neuling <mikey at neuling.org> writes:
> > On DD2.0 parts, PCIe ECC protection is not warranted in the response
> > data path. Thus, for these parts, we need to flag any ECC errors
> > detected from the adjacent AIB RX Data path so the part can be
> > replaced.
> > 
> > This patch configures the FIRs so that we escalate these AIB ECC
> > errors to a checkstop so the parts can be replaced.
> > 
> > Signed-off-by: Michael Neuling <mikey at neuling.org>
> > ---
> >  hw/phb4.c | 43 ++++++++++++++++++++++++++++++++++---------
> >  1 file changed, 34 insertions(+), 9 deletions(-)
> 
> I'm assuming this should also be Cc:stable ?

Anything that's needed for dd2.01.  I think boston/p9dsu firmware is based on
v5.9 so it should go there, but if we do, can we pull in these two also?

   commit 411dc0813f24d2b282dbd1ff75b71671b60c7b40
   Author: Russell Currey <ruscur at russell.cc>
   Date:   Tue May 1 14:24:55 2018 +1000
   phb4: Hardware init updates
       
and

   commit 9a83ab711ea3c76919f311cb1c78e051ae59c808
   Author: Benjamin Herrenschmidt <benh at kernel.crashing.org>
   Date:   Wed Aug 15 15:10:35 2018 +1000
   phb4: Workaround PHB errata with CFG write UR/CA errors


> I've merged to master at least as of 7dbf80d1db4508502f667deccf44a970fc12c107

Thanks!

Mikey


More information about the Skiboot mailing list