[Skiboot] [PATCH 4/7] capp/phb4: Force CAPP to PCIe mode during kernel shutdown

Vaibhav Jain vaibhav at linux.ibm.com
Mon Sep 24 15:28:25 AEST 2018

Thanks for reviewing this patch Fred,

Frederic Barrat <fbarrat at linux.ibm.com> writes:

>> +	if (rc == OPAL_BUSY) {
>> +		/* Run the phb reset state machine */
>> +		rc = slot->ops.run_sm(slot);
>> +	}
> Nitpick, but since you're preparing a new version: at this point, the 
> comment looks weird, since there's no reason for a reset to occur, we 
> haven't changed the state of the slot yet. It's coming in a later patch, 
> by calling creset from set_capi_mode()
Agreed, will fix this comment in v2.

Vaibhav Jain <vaibhav at linux.ibm.com>
Linux Technology Center, IBM India Pvt. Ltd.

More information about the Skiboot mailing list