[Skiboot] [PATCH] hdata: Explain what the xscom node bus-frequency is

Oliver O'Halloran oohall at gmail.com
Thu Sep 20 15:03:26 AEST 2018


Vague documentation is about as annoying as no documentation.

Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
---
 hdata/spira.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/hdata/spira.c b/hdata/spira.c
index 2dd0dd362409..5621870928ed 100644
--- a/hdata/spira.c
+++ b/hdata/spira.c
@@ -281,7 +281,10 @@ static struct dt_node *add_xscom_node(uint64_t base, uint32_t hw_id,
 	}
 	dt_add_property_u64s(node, "reg", addr, size);
 
-	/* Derive bus frquency */
+	/*
+	 * The bus-frequency of the xscom node is actually the PIB/PCB
+	 * frequency. It is derived from the nest-clock via a 4:1 divider
+	 */
 	freq = dt_prop_get_u64_def(dt_root, "nest-frequency", 0);
 	freq /= 4;
 	if (freq)
-- 
2.9.5



More information about the Skiboot mailing list