[Skiboot] [PATCH 2/7] opal: Introduce opal_del_host_sync_notifier_with_data()

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Wed Sep 19 19:16:09 AEST 2018

On 09/15/2018 08:09 PM, Vaibhav Jain wrote:
> Current implementation of opal_del_host_sync_notifier() will only
> delete the first entry of the 'notify' callback found from opal_syners
> list irrespective of the 'data' of list-node. This is problematic when
> multiple notifiers with same callback function but different 'data'
> are registered. In this case when the cleanup code will call
> opal_del_host_sync_notifier() it cannot be sure if correct opal_syncer
> is removed.

Patch itself looks good to me. But may be its better to convert existing
opal_del_host_sync_notifier() itself? Anyway no one is using that interface 
today and nothing
harm is adding additional check for `data` as well.


More information about the Skiboot mailing list