[Skiboot] [PATCH] SBE-p8: Do all sbe timer update with xscom lock held

Stewart Smith stewart at linux.ibm.com
Tue Sep 18 17:41:34 AEST 2018

Stewart Smith <stewart at linux.ibm.com> writes:
> Without this, on some P8 platforms, we could (falsely) think the SBE timer
> had stalled getting the dreaded "timer stuck" message.
> The code was doing the mftb() to set the start of the timeout period while
> *not* holding the lock, so the 1ms timeout started sometime when somebody
> else had the xscom lock.
> The simple solution is to just do the whole routine holding the xscom lock,
> so do it that way.
> Signed-off-by: Stewart Smith <stewart at linux.ibm.com>
> ---
>  hw/sbe-p8.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

Merged to master as of da773b275e62b280b81892bc65fc5815d4a9d80

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list