[Skiboot] [PATCH 3/7] core/pci: Introduce a new pci_slot_op named completed_sm_run()
vaibhav at linux.ibm.com
Mon Sep 17 19:12:06 AEST 2018
Thanks for reviewing this patch Andrew:
Andrew Donnellan <andrew.donnellan at au1.ibm.com> writes:
>> int64_t (*run_sm)(struct pci_slot *slot);
>> + void (*completed_sm_run)(struct pci_slot *slot, uint64_t err);
> Is there a reason this can't be an int64_t like the others? I mean, I'm
> not sure what kind of failures we'd report...
Go idea, This can return a int64_t so that any slot cleanup errors be
communicated back. It was also override an error messages reported
during the reset.
> This seems a good idea to me, so:
> Reviewed-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>
Vaibhav Jain <vaibhav at linux.vnet.ibm.com>
Linux Technology Center, IBM India Pvt. Ltd.
More information about the Skiboot