[Skiboot] [PATCH 2/7] opal: Introduce opal_del_host_sync_notifier_with_data()

Andrew Donnellan andrew.donnellan at au1.ibm.com
Mon Sep 17 18:30:05 AEST 2018


On 16/9/18 12:39 am, Vaibhav Jain wrote:
> Current implementation of opal_del_host_sync_notifier() will only
> delete the first entry of the 'notify' callback found from opal_syners
> list irrespective of the 'data' of list-node. This is problematic when
> multiple notifiers with same callback function but different 'data'
> are registered. In this case when the cleanup code will call
> opal_del_host_sync_notifier() it cannot be sure if correct opal_syncer
> is removed.
> 
> Hence we introduce a new function named
> opal_del_host_sync_notifier_with_data() that iterates over the
> opal_syncers list and only removes the first node node having the
> matching value for 'notify' callback and 'data'.
> 
> Signed-off-by: Vaibhav Jain <vaibhav at linux.ibm.com>

Reviewed-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited



More information about the Skiboot mailing list