[Skiboot] [PATCH 2/2] nvram: Fix wait-for-nvram message

Oliver O'Halloran oohall at gmail.com
Mon Sep 17 17:53:16 AEST 2018

We print a message when nvram_query() needs to wait for the NVRAM to
be loaded from the BMC/FSP. Currently this is printed at PR_WARNING
which is excessive since this doesn't actually indicate that anything is
wrong. There's also nothing that we can really do about loading the
NVRAM being slow, so just print this at PR_DEBUG.

Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
 core/nvram-format.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/core/nvram-format.c b/core/nvram-format.c
index fc8e24820e5e..37c5cd5c5839 100644
--- a/core/nvram-format.c
+++ b/core/nvram-format.c
@@ -220,8 +220,9 @@ const char *nvram_query(const char *key)
 	if (!nvram_has_loaded()) {
-		prlog(PR_WARNING, "NVRAM: Query before is done loading\n");
-		prlog(PR_WARNING, "NVRAM: Waiting for load\n");
+		prlog(PR_DEBUG,
+			"NVRAM: Query for '%s' must wait for NVRAM to load\n",
+			key);
 		if (!nvram_wait_for_load()) {
 			prlog(PR_CRIT, "NVRAM: Failed to load\n");
 			return NULL;

More information about the Skiboot mailing list