[Skiboot] [PATCH skiboot] npu2: Use correct kill type for TCE invalidation

Alexey Kardashevskiy aik at ozlabs.ru
Wed Sep 12 19:29:17 AEST 2018


kill_type is enum of OPAL_PCI_TCE_KILL_PAGES, OPAL_PCI_TCE_KILL_PE,
OPAL_PCI_TCE_KILL_ALL and phb4_tce_kill() gets it right but
npu2_tce_kill() uses OPAL_PCI_TCE_KILL which is an OPAL API token.

This fixes an obvious mistype.

Signed-off-by: Alexey Kardashevskiy <aik at ozlabs.ru>
---
 hw/npu2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/npu2.c b/hw/npu2.c
index d05eb66..73749ec 100644
--- a/hw/npu2.c
+++ b/hw/npu2.c
@@ -1351,7 +1351,7 @@ static int64_t npu2_tce_kill(struct phb *phb, uint32_t kill_type,
 		 * NPU2 doesn't support killing a PE so fall through
 		 * and do a kill all instead.
 		 */
-	case OPAL_PCI_TCE_KILL:
+	case OPAL_PCI_TCE_KILL_ALL:
 		npu2_write(npu, NPU2_ATS_TCE_KILL, NPU2_ATS_TCE_KILL_ALL);
 		break;
 	default:
-- 
2.11.0



More information about the Skiboot mailing list