[Skiboot] [PATCH] opal/hmi: Ignore debug trigger inject core FIR.

Vaibhav Jain vaibhav at linux.vnet.ibm.com
Fri Sep 7 15:36:28 AEST 2018


Mahesh J Salgaonkar <mahesh at linux.vnet.ibm.com> writes:

> From: Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com>
>
> Core FIR[60] is a side effect of the work around for the CI Vector Load
> issue in DD2.1. Usually this gets delivered as HMI with HMER[17] where
> Linux already ignores it. But it looks like in some cases we may happen
> to see CORE_FIR[60] while we are already in Malfunction Alert HMI
> (HMER[0]) due to other reasons e.g. CAPI recovery or NPU xstop. If that
> happens then just ignore it instead of crashing kernel as not recoverable.
>
> Signed-off-by: Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com>
> ---
>  core/hmi.c |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/core/hmi.c b/core/hmi.c
> index d9240ceeb..75f316ac8 100644
> --- a/core/hmi.c
> +++ b/core/hmi.c
> @@ -232,7 +232,6 @@ static const struct core_xstop_bit_info {
>  	{ 48, CORE_CHECKSTOP_PC_HYP_RESOURCE },
>  	{ 52, CORE_CHECKSTOP_PC_HANG_RECOV_FAILED },
>  	{ 54, CORE_CHECKSTOP_PC_AMBI_HANG_DETECTED },
> -	{ 60, CORE_CHECKSTOP_PC_DEBUG_TRIG_ERR_INJ },
>  	{ 63, CORE_CHECKSTOP_PC_SPRD_HYP_ERR_INJ },
>  };
>

Looks good to me. Thanks for fixing this.

Reviewed-by: Vaibhav Jain <vaibhav at linux.ibm.com>

-- 
Vaibhav Jain <vaibhav at linux.vnet.ibm.com>
Linux Technology Center, IBM India Pvt. Ltd.



More information about the Skiboot mailing list