[Skiboot] [PATCH] hdata: Make sure reserved node name starts with "ibm, "

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Thu Sep 6 22:18:28 AEST 2018

On 06/26/2018 07:13 PM, Oliver wrote:
> On Tue, Jun 26, 2018 at 9:56 PM, Vasant Hegde
> <hegdevasant at linux.vnet.ibm.com> wrote:
>> On 06/25/2018 08:03 AM, Oliver wrote:
>>> On Sat, Jun 23, 2018 at 4:23 PM, Vasant Hegde
>>> <hegdevasant at linux.vnet.ibm.com> wrote:
>>>> HDAT does not use consistent label format for reserved memory label.
>>>> Few starts with "ibm," while few other starts with component name.
>>>> Lets make sure all the reserved node name starts with "ibm,".


>> Oh yeah. I missed prd-label issue. I do not wanted to change `trace-area`
>> stuff. Hence I fixed it here.
>> Are we fine with converting "trace-area" label to "ibm,trace-area" ? if so I
>> can move this
>> fix to add_hb_reserve_node().
> Currently nothing on the host uses the trace-area stuff so renaming it
> is fine. A trace reservation only exists in HDAT when someone
> configures cronus or the FSP (via attribute overrides) to reserve some
> system memory for use as a nHTM trace buffer. Nothing on the host
> looks at that reservation so we should be fine.

Thanks! Will send v2 soon.


More information about the Skiboot mailing list