[Skiboot] [PATCH] errorlog: Rename PHB3 to just PHB
Vasant Hegde
hegdevasant at linux.vnet.ibm.com
Thu Sep 6 15:32:36 AEST 2018
On 08/29/2018 12:43 PM, Russell Currey wrote:
> I don't see a reason why there would need to be a PHB3 *specific*
> subsystem in the error logs, so rename it to PHB so that PHB4 and
> later can use it too without continually redefining it.
>
> This shouldn't change any existing assumptions because it's unused.
>
> Signed-off-by: Russell Currey <ruscur at russell.cc>
> ---
> include/errorlog.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/errorlog.h b/include/errorlog.h
> index 285c185d..6da96649 100644
> --- a/include/errorlog.h
> +++ b/include/errorlog.h
> @@ -175,7 +175,7 @@ struct opal_err_info {
> #define OPAL_UART 0x5541 /* UA */
> #define OPAL_OCC 0x4F43 /* OC */
> #define OPAL_OP_PANEL 0x4F50 /* OP */
> -#define OPAL_PHB3 0x5048 /* PH */
> +#define OPAL_PHB 0x5048 /* PH */
IIRC original idea was to have separate component ID for different PHB's.
But we never added PEL format error logs to these components.
Reviewed-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
-Vasant
More information about the Skiboot
mailing list