[Skiboot] [PATCH] core/cpu: Fix memory allocation for job array

Vaidyanathan Srinivasan svaidy at linux.vnet.ibm.com
Mon Sep 3 20:37:32 AEST 2018


* Nicholas Piggin <npiggin at gmail.com> [2018-09-03 15:46:28]:

> On Sun,  2 Sep 2018 15:29:09 +0530
> Vaidyanathan Srinivasan <svaidy at linux.vnet.ibm.com> wrote:
> 
> > fixes: 7a3f307e core/cpu: parallelise global CPU register setting jobs
> > 
> > This bug would result in boot-hang on some configurations due to
> > cpu_wait_job() endlessly waiting for the last bogus jobs[cpu->pir] pointer.
> 
> Dang, good catch, so *that's* what the bug was. You'd better
> fix my broken cpu_cleanup_all as well.

Yes, I will add same fix in cpu_cleanup_all().  I should have looked
other places as well. I just stopped after this fix booted the machine.

--Vaidy



More information about the Skiboot mailing list