[Skiboot] [PATCH] phb4/capp: Update the expected Eye-catcher for CAPP ucode lid
vaibhav at linux.ibm.com
Mon Sep 3 18:52:55 AEST 2018
Thanks for reviewing this patch Andrew,
Andrew Donnellan <andrew.donnellan at au1.ibm.com> writes:
> On 03/09/18 17:43, Vaibhav Jain wrote:
>> Currently on P9 load_capp_code() expects CAPP ucode lid header to have
>> eye-catcher magic of 'CAPPPSLL'. However the ucode lid available on a
>> FSP base system has eye-catcher magic of 'CAPPLIDH'. This prevents
>> skiboot from loading the ucode with this error message:
>> CAPP: ucode header invalid
>> We fix this issue by updating load_capp_ucode() to use the eye-catcher
>> value of 'CAPPLIDH' instead of 'CAPPPSLL'.
>> Signed-off-by: Vaibhav Jain <vaibhav at linux.ibm.com>
> Should this go to stable?
Yes, will resend marking it to stable.
> Is there anywhere where this change is documented? What about non-FSP
Yes, as discussed offline CAPP ucode only lids for FSP based systems
have CAPPLIDH as the header magic. Hence this needs to be changed.
Openpower based systems dont use a lid and pnor partition data
containing capp ucode has magic 'CAPPULID'. So this condition is already
handled in capp_load_ucode() and openpower based systems are not
effected by this patch.
Vaibhav Jain <vaibhav at linux.vnet.ibm.com>
Linux Technology Center, IBM India Pvt. Ltd.
More information about the Skiboot